jajuk-team / jajuk

Advanded jukebox for users with large or scattered music collections
48 stars 19 forks source link

refactor: move webradios URL #2036

Closed bflorat closed 3 years ago

bflorat commented 4 years ago

http://svn2.assembla.com/svn/common-jukebox/common-jukebox/src/main/resources/preset_radios.xml : to be moved to github ?

gkerdal commented 4 years ago

I agree, what do you think of putting this file in the release section ?

https://github.com/jajuk-team/jajuk/releases

bflorat commented 4 years ago

Why not but does the final URL would then depend on the version ?

Alternatives include :

gkerdal commented 4 years ago

I'm not a github expert but is it possible to create a version or a tag called "Ressources" and put the preset_radios.xml file as an asset ?

gkerdal commented 4 years ago

According to github documentation, the tag name should follow naming convention of git tag.

So I would suggest to create a special project, jajuk-resources by exemple, to keep this kind of files. The release would be 1.0 with the file as an asset.

The final link would be : https://github.com/jajuk-team/jajuk-resources/releases/1.0/preset_radios.xml

If you agree, I can create the project.

bflorat commented 4 years ago

OK, please create a new project.

However, why using a tag version in URL ? why not : https://github.com/jajuk-team/jajuk-resources/master/preset_radios.xml ?

gkerdal commented 4 years ago

I don't have permission access on github to create a new repository for jajuk-team. Could you create it ?

You're right, I agree to point to master instead of releases, let's keep it simple.

bflorat commented 4 years ago

Done https://github.com/jajuk-team/resources

gkerdal commented 4 years ago

I don't have commit permission or 'write access' on resources project, could you give me permission ? Thanks.

bflorat commented 4 years ago

I gave you admin rights on it, is it ok now ?

gkerdal commented 4 years ago

Yes, Thanks.

Direct link https://github.com/jajuk-team/jajuk-resources/master/preset_radios.xml doesn't work We should use : https://raw.githubusercontent.com/jajuk-team/resources/master/preset_radios.xml

gkerdal commented 4 years ago

Done.