Closed pmagunia closed 10 years ago
Never though someone with PHP 5.5. is actually using this class. If perhaps would keep the defaults and just add one if in case that function exists and then overwrite that single setting.
For the comma with the array, if it wasn't there in the first place, there is no need to add it (albeit I think it's good code style, but I would not do it here, as it changes a line that has nothing to do with the commit actually).
So if you would like to update the pull request, just do. If not, let me know, then I would do it. Thanks!
I think I have changes looking the way you requested though I can't figure out how to squash the pull request into a single commit. I can create a new pull request if the final changes look OK. If you would like to close this pull request and commit the changes yourself that's fine with me too.
Sent from my iPad
On Apr 20, 2014, at 10:10 AM, hakre notifications@github.com wrote:
Never though someone with PHP 5.5. is actually using this class. If perhaps would keep the defaults and just add one if in case that function exists and then overwrite that single setting.
For the comma with the array, if it wasn't there in the first place, there is no need to add it (albeit I think it's good code style, but I would not do it here, as it changes a line that has nothing to do with the commit actually).
So if you would like to update the pull request, just do. If not, let me know, then I would do it. Thanks!
— Reply to this email directly or view it on GitHub.
Duplicate of #22 ; fixed in 36db8b5
@Tetragy I now finally put a fix for this into master. I have yet changed it completely differently now with a subroutine handling the different PHP versions. It took longer than expected but finally it's in.
Few minor changes to remove the PHP 5.5 warning when using @filename API for cURL.