jakala-na / next-contentful-starterkit

https://next-contentful-starterkit.vercel.app/
MIT License
2 stars 0 forks source link

Replace CVA with Tailwind Variants #34

Closed victorpavlov closed 2 months ago

victorpavlov commented 6 months ago

Tailwind Variants ads pretty neat features that are hard to achieve using just CVA. For example, it gives slots to describe each element inside the component. You can also have Responsive variants, Slots with responsive variants, Compound slots.

asgorobets commented 6 months ago

@mrtag23 Need your thoughts on this too

mrtag23 commented 6 months ago

@asgorobets if we're going to mono-repo - bare minimum approach, I would honestly simplify the UI as much as possible. As we discussed having shadncn as a base layer should probably be more than enough. We can add additional tools later when the need arises and in case the tool appears to be often required we can make an integration PR and make it a part of the main repo.

asgorobets commented 2 months ago

Closing as the point was to provide one solution of handling variants, and cva ships from shadcn and makes it an ok default to have