search

jakartaee / authentication

Jakarta Authentication
https://eclipse.org/ee4j/jaspic
Other
24 stars 33 forks source link

Prepare new Authentication TCK #150

Closed arjantijms closed 2 years ago

arjantijms commented 2 years ago
  1. [x] Copying tests to /tck in this project.
  2. [x] Changing package names to ee.jakarta.tck
  3. [x] Adding (additional) comments to test
  4. [x] Incorporating the existing TCK from https://github.com/eclipse-ee4j/jakartaee-tck
  5. [x] Creating single zip distribution of the entire TCK
  6. [x] Create / update guide / docs on how to run the TCK
  7. [ ] Adding example to run TCK as dependency from Maven into your own pom. (see https://github.com/piranhacloud/piranha/tree/current/external/tck/jwt)
starksm64 commented 2 years ago

@arjantijms What is the subtree under https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests for the authentication tests?

arjantijms commented 2 years ago

@starksm64 that is https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jaspic

arjantijms commented 2 years ago

Note we don't necessarily need to have the Authentication (JASPIC) sources transferred to this repo. We could do that at a later date too.

alwin-joseph commented 2 years ago

Note we don't necessarily need to have the Authentication (JASPIC) sources transferred to this repo. We could do that at a later date too.

Does this mean the existing JASPIC TCK need not be run or to use https://github.com/eclipse-ee4j/glassfish/blob/master/appserver/tests/tck/authentication/pom.xml with modifications to integrate the existing TCK from https://github.com/eclipse-ee4j/jakartaee-tck. If we are to incorporate the existing TCK in this way, the bundle will have to be hosted at a location so that it can be run from the new TCK.

arjantijms commented 2 years ago

to use https://github.com/eclipse-ee4j/glassfish/blob/master/appserver/tests/tck/authentication/pom.xml with modifications to integrate the existing TCK from https://github.com/eclipse-ee4j/jakartaee-tck.

That option. The existing TCK would then be run like https://github.com/eclipse-ee4j/glassfish/blob/master/appserver/tests/tck/authentication/pom.xml

If we are to incorporate the existing TCK in this way, the bundle will have to be hosted at a location so that it can be run from the new TCK.

Indeed, it's not super ideal as we'd be hosting two bundles then, but with only days to go, maybe attempting to transfer the source at this point is too time consuming and we'd better invest that time in making sure the Faces and Security TCKs are fully up and running.

starksm64 commented 2 years ago

@arjantijms I see @alwin-joseph created a PR to kickstart the userguide. I can take a look at verifying it once merged.

starksm64 commented 2 years ago

The TCK userguide needs to be updated to reflect the use of maven/arquillian. I'm working on that.

arjantijms commented 2 years ago

@starksm64 thanks!

starksm64 commented 2 years ago

156 provides an adequate userguide and updates the TCK zip to meet the requirements

arjantijms commented 2 years ago

Thanks @starksm64

The TCK is now available from https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-authentication-tck-3.0.0-dist.zip and should be sufficient for ratification.

The example for another server can be done at a later time.

alwin-joseph commented 2 years ago

The https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-authentication-tck-3.0.0.zip is the old TCK built from jakartaee-tck . The https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-authentication-tck-3.0.0-dist.zip is the final official TCK.

The old tck is executed(against glassfish only for now) from final TCK using the tck runner script at tck/old-tck-runner/pom.xml.

The final/official TCK should be used for ballot.

alwin-joseph commented 2 years ago

@arjantijms Is the new TCK run job created in authentication Jenkins instance? If possible please share the result where the new tests and old tck are passing.

cc @scottmarlow

arjantijms commented 2 years ago

Hi,

The TCK archive is build on ci.eclipse.org/es, since during the weekend that one had upload rights.

The created archive is unpacked executed via ci.eclipse.org/authentication

See:

https://ci.eclipse.org/authentication/job/2_authentication_run_tck_against_staged_build https://ci.eclipse.org/authentication/job/2_authentication_run_tck_against_staged_build/configure

Kind regards, Arjan Tijms

On Monday, May 2, 2022, Alwin Joseph @.***> wrote:

@arjantijms https://github.com/arjantijms Is the new TCK run job created in authentication Jenkins instance? If possible please share the result where the new tests and old tck are passing.

cc @scottmarlow https://github.com/scottmarlow

— Reply to this email directly, view it on GitHub https://github.com/jakartaee/authentication/issues/150#issuecomment-1114952358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFOTX62BRWPU2HAEJOSS3VH7QDNANCNFSM5R4GK3EQ . You are receiving this because you were mentioned.Message ID: @.***>

arjantijms commented 2 years ago

The new authentication TCK is there! Thanks to everyone involved. We have some more enhancements to do, but we can track that work in a 4.0.1 service release issue.