search

jakartaee / authentication

Jakarta Authentication
https://eclipse.org/ee4j/jaspic
Other
24 stars 33 forks source link

TCK Challenge: ServletProfileSPITest#CheckMsgInfoKey #219

Open markt-asf opened 2 months ago

markt-asf commented 2 months ago

There is one definite issue and one possible issue with this test.

  1. Hard-coded requirement for Jakarta Authorization support. 
    
boolean bIs115Compatible = false;

// ONLY if we are Jakarta Authorization compatible, we want to make an additional key test if (bIs115Compatible) { ...


That boolean value needs to be externally configurable.

Once that has been addressed, there is a possible second issue with the alternative code branch

2. The `CallerPrincipalCallback` check expects the user name to be set to `j2ee` but the user name isn't set until `PasswordValidationCallback` is called which happens after `CallerPrincipalCallback`. I do not see how the test can pass in its current form.

It is quite possible that the second issue is a problem with my understanding rather than the TCK. If, so any pointers to where I am going wrong would be appreciated.