search

jakartaee / cdi-tck

CDI TCK
Apache License 2.0
46 stars 44 forks source link

Updated to Java SE 17 for build and use SE 11 as build target #512

Closed Ladicek closed 7 months ago

Ladicek commented 10 months ago

Due to the dependency on JPA 3.2.0-M1, the CDI TCK doesn't build with Java 11 anymore. It feels like we should at least bump the various properties in the POMs to signal that 17 is the minimum now.

manovotn commented 10 months ago

@starksm64 wasn't 11 the agreed on minimum for all specs? Or are the TCKs allowed to differ?

Emily-Jiang commented 10 months ago

@starksm64 wasn't 11 the agreed on minimum for all specs? Or are the TCKs allowed to differ?

The minimum Java version for component specs are decided by the spec groups, which varies between the specs. Java 21 is the minimum Java version for EE 11 (platform, web profile and core profile) but component specs might choose a lower version of the Java.

Emily-Jiang commented 10 months ago

For Jakarta Persistence, its plan review says the minimum version is Java 17. This means CDI should update its minimum Java version to be Java 17 as well.

starksm64 commented 10 months ago

@manovotn No, technically the minimum could be 21 for the TCK as that is what component specs are free to choose. I have raised it to 17 for now as that is what JPA required. We can fine tune the modules and have the core compile with 11 and the Web will move to the platform, so it won't impact the remaining core TCK.

starksm64 commented 7 months ago

So we can leave this at SE 11 as the target and use a Java SE 17 JDK to compile to that target to avoid issues with the references to the EL interfaces used by the BeanManager.