search

jakartaee / cdi-tck

CDI TCK
Apache License 2.0
46 stars 45 forks source link

Synchronize on Weld release for a 4.1.0.Beta1 TCK release #539

Closed starksm64 closed 8 months ago

starksm64 commented 9 months ago

I would like to synch on a Weld release that picks up the 4.1.0.Beta1 cdi api update so we can produce a 4.1.0.Beta1 cdi tck that includes the outstanding PRs. I merged #518 assignability tests, #502 looks ready, and then #532 should be ready.

manovotn commented 9 months ago

Yes, I intend to work on that next.

502 should definitely get in - I will be focusing on getting that working in Weld next.

As for https://github.com/jakartaee/cdi-tck/pull/532, I am not sure that should be in TCK Beta1 as the CDI API Beta1 doesn't contain the spec text removal either (https://github.com/jakartaee/cdi/commits/main/). Either way, that should be a minor thing WRT to having a passing impl anyway.

starksm64 commented 9 months ago

That is fine, I can do a Beta 2 that just has the integration spec/tck removals next week.

starksm64 commented 9 months ago

@manovotn Is there an ETA for the next Weld release? Is there anything you need help with?

manovotn commented 8 months ago

I was preoccupied elsewhere, I am working on it now.

The list of known issues is over at JIRA but I will shift most of them past Beta to get a release out ASAP. [EDIT: I have shifted most to Beta2 already] I already have release of Weld parent and Beta of Weld API and I am working on a PR for core - https://github.com/weld/core/pull/2911.

It is all built against M1 TCK (although I tested locally against master) as I tried to create a Beta TCK release yesterday but Jenkins probably had some maintenance and was inaccessible. Doesn't really matter though.

Is there anything you need help with?

I think I can handle the Beta fine but if you want to help past that, I could use a hand with re-configuring the testing setup in Weld once the TCK web module gets migrated into platform TCKs. I assume this will happen for RC release, right?

manovotn commented 8 months ago

I think I should be able to get the release out tomorrow.

starksm64 commented 8 months ago

I think I can handle the Beta fine but if you want to help past that, I could use a hand with re-configuring the testing setup in Weld once the TCK web module gets migrated into platform TCKs. I assume this will happen for RC release, right?

Removal from the CDI TCK will happen after Beta1, which I'll do as soon as there is a new Weld release. I'll do an RC1 right after that has the Jakarta EE integration concerns in the spec and TCK removed. We are supposed to be targeting a final release this coming week.

manovotn commented 8 months ago

@starksm64 Weld 6.0.0.Beta1 should be syncing to Central right now.

starksm64 commented 8 months ago

I see it, working on the TCK release now.

starksm64 commented 8 months ago

The 4.1.0.Beta1 TCK has been pushed out