search

jakartaee / common-annotations-api

Jakarta Annotations
https://eclipse.org/ee4j/ca
Other
51 stars 38 forks source link

[StepSecurity] Apply security best practices #113

Open step-security-bot opened 1 year ago

step-security-bot commented 1 year ago

Summary

This pull request is created by Secure Repo at the request of @fperezel. Please merge the Pull Request to incorporate the requested changes. Please tag @fperezel on your message if you have any questions related to the PR. You can also engage with the StepSecurity team by tagging @step-security-bot.

Security Fixes

resolve: #112

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Feedback

For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-repo. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

lukasj commented 1 year ago

@fperezel yaml file allows comment - is there any reason to not include license header in this file?

ghost commented 1 year ago

@fperezel yaml file allows comment - is there any reason to not include license header in this file?

Hi @lukasj ,

The file is generated based on a template thus by default it doesn't include comments about license header. Besides, this is a github files to configure dependabot. So I am wondering which type of incense should include.

Can you tell me more about which license should be added and provide me an example?

Thanks,

lukasj commented 1 year ago

@fperezel I usually add the license the project itself is said to use, so in this particular case it should be an EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0, see ie the project pom for the text; an example with different license is ie here

ghost commented 1 year ago

@fperezel I usually add the license the project itself is said to use, so in this particular case it should be an EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0, see ie the project pom for the text; an example with different license is ie here

Hi @lukasj

Thanks for the example and I have already update the PR

Please, don't hesitate and let me know if there is something more needed.

Thanks