search

jakartaee / common-annotations-api

Jakarta Annotations
https://eclipse.org/ee4j/ca
Other
53 stars 40 forks source link

travis build #38

Closed rotty3000 closed 5 years ago

rotty3000 commented 5 years ago

@waynebeaton if you or someone with better knowledge of the eclipse infra can take a quick look to see if this is suitable to bootstrap the travis build I'd appreciate it.

m0mus commented 5 years ago

It looks good to me. I assume that you tested it and it works.

m0mus commented 5 years ago

@lukasj can you take a look on this?

rotty3000 commented 5 years ago

@m0mus how am I supposed to test this to make sure it works I cannot myself make this integration work. We need some help to assert this.

lukasj commented 5 years ago

Once you connect your account (rotty3000) to travis, travis should automagically run builds from your travis-enabled branch.

rotty3000 commented 5 years ago

@lukasj my account is already in travis!

rotty3000 commented 5 years ago

I had to manually enable this repo in my jenkins profile!

rotty3000 commented 5 years ago

It looks like javadoc doclint is failing on java 11.

rotty3000 commented 5 years ago

solution to javadoc issue https://bugs.openjdk.java.net/browse/JDK-8212233

You can see the passing build here https://travis-ci.org/rotty3000/common-annotations-api

rotty3000 commented 5 years ago

@lukasj is this fine now?

lukasj commented 5 years ago

alternative solution to the javadoc build problem is to turn of detectApiLink - not sure which one is better. I'm generally fine with whatever works in this particular case

rotty3000 commented 5 years ago

trying both suggestions! let's see...

rotty3000 commented 5 years ago

Ok @lukasj everything is good with your suggestions https://travis-ci.org/rotty3000/common-annotations-api

lukasj commented 5 years ago

@m0mus feel free to merge this - I'm not a committer in this project...

rotty3000 commented 5 years ago

Can I get anyone to bless this please?

rotty3000 commented 5 years ago

@m0mus this merge will break the travis build because the spec has an enforced limitation to build only on Java 8.

rotty3000 commented 5 years ago

Should I remove the upper bound?