jakartaee / common-annotations-api

Jakarta Annotations
https://eclipse.org/ee4j/ca
Other
53 stars 39 forks source link

Allow use EL in DataSourceDefinition #95

Open hantsy opened 2 years ago

hantsy commented 2 years ago

Currently Payara/GF and WildFLy add reading env variable support in DataSourceDefinition, but it is better to support standard EL in the DataSourceDefinition properties.

eg. Read from Jakarta Config properties via System environment variables.

  @DataSourceDefinition(name="#{env.DS_JNDI}",// or #{env['DS_JNDI']}
      className="#{env.DS_CLASSNAME}",
      port="#{env.DS_PORT}",
      host="#{env.DS_HOST}",
      user="#{env.DS_USERNAME}",
      password="#{env.DS_PASSWORD}",
    )

Read from Jakarta Config properties.

  @DataSourceDefinition(name="#{datasource.jndi}",
      className="#{datasource.classname}",
      port="#{datasource.port}",
      host="#{datasource.host}",
      user="#{datasource.username}",
      password="#{datasource.password}",
    )
hantsy commented 2 years ago

I am not sure why this annotation is not located in Jdbc.