jakartaee / concurrency

Eclipse Project for Concurrency Utilities
https://projects.eclipse.org/projects/ee4j.cu
Other
66 stars 38 forks source link

[Release]: 3.0.4 service release #374

Open KyleAure opened 7 months ago

KyleAure commented 7 months ago

Proposal

If we were to create a 3.0.4 service release I wanted an issue open to track changes we would want to put in

Outstanding work

Check List

Prepare

KyleAure commented 1 week ago

3.0.4 is Staged

Verification Data

file sha256
concurrency-tck-3.0.4.zip aa29bfc0bab42d9aa2da518208d9e92cdde80fc17b00dd658954dfd36064a426

@scottmarlow can you test this staged TCK with Wildfly and let me know if there are any other changes you need in this service release. Once I hear back from you I'll go ahead with a publishing this.

jamezp commented 1 week ago

This is passing on WildFly. One important thing to note here is there is a requirement to use jakarta.tck:sigtest-maven-plugin:2.3 here. Older versions will not work because of the change to -IgnoreJDKClass.

OT: I'm working with @scottmarlow to somewhat revert this. IoW revert the -IgnoreJDKClass to work as it did before and add a -IgnoreJDKClasses argument instead. See https://github.com/eclipse-ee4j/jakartaee-tck-tools/issues/39

KyleAure commented 1 week ago

@jamezp I did update the TCK Distribution user guide which says:

https://github.com/jakartaee/concurrency/blob/4c30daf1dfd797826fa8e3b1cb67ce2bddae0999/tck-dist/src/main/asciidoc/concurrency-tck-reference-guide.adoc?plain=1#L99

https://github.com/jakartaee/concurrency/blob/4c30daf1dfd797826fa8e3b1cb67ce2bddae0999/tck-dist/src/main/asciidoc/concurrency-tck-reference-guide.adoc?plain=1#L435

So it should be clear that users need to use specifically the 2.3 version of the plugin. If you think anymore documentation should be added let me know. Otherwise, I'll go forward with releasing this.

jamezp commented 1 week ago

@KyleAure No, I think that is sufficient. We were using a very old version anyway :) I say go forward with the release.

KyleAure commented 1 week ago

3.0.4 is Released

Verification Data

file sha256
concurrency-tck-3.0.4.zip aa29bfc0bab42d9aa2da518208d9e92cdde80fc17b00dd658954dfd36064a426