jakartaee / concurrency

Eclipse Project for Concurrency Utilities
https://projects.eclipse.org/projects/ee4j.cu
Other
68 stars 38 forks source link

Concurrency 3.1 Finalization #507

Closed edbratt closed 3 months ago

edbratt commented 4 months ago

Congratulations, the Release Review ballot has completed successfully. Please perform the following tasks to finalize the release:

KyleAure commented 4 months ago

@edbratt - Thanks for the follow up!

The only part I'm not sure on are the schemas. We did make updates to the schema to add virtual and qualifier elements under this PR: https://github.com/jakartaee/jakartaee-schemas/pull/44 I did not fully integrate these schema updates to servlet and there is an outstanding PR to fix that: https://github.com/jakartaee/jakartaee-schemas/pull/48 Which has not been approved. Also the link on how to publish these schemas is broken: https://jakartaee.github.io/jakartaee/publish-xml-schemas

Can you approve the outstanding PR and get it merged? And give me a link to the instructions on how to publish these?

arjantijms commented 4 months ago

Hi @KyleAure to publish the schemas, you can take a look at this example:

https://github.com/jakartaee/jakarta.ee/pull/1935

It's essential a PR against the Jakarta.ee website.

edbratt commented 4 months ago

I am guessing you are observing that the link 'How to publish XML Schemas' in https://github.com/jakartaee/jakartaee-schemas is incorrect. Try this How to Publish XML Schemas -- It seems to incorrect in a few places (likely due to moving the project from one GHO to another). I've submitted PRs to fix.