jakartaee / concurrency

Eclipse Project for Concurrency Utilities
https://projects.eclipse.org/projects/ee4j.cu
Other
68 stars 38 forks source link

Update signature test plugin to jakarta.tck varient #523

Closed KyleAure closed 3 months ago

KyleAure commented 3 months ago

Fixes #510

Local test results:

[6/11/24, 10:51:42:569 CDT] 0000004a k.concurrent.common.signature.ConcurrencySignatureTestRunner I ******************************************************
******************************************************
All package signatures passed.
    Passed packages listed below: 
        jakarta.enterprise.concurrent(static mode)
        jakarta.enterprise.concurrent(reflection mode)
        jakarta.enterprise.concurrent.spi(static mode)
        jakarta.enterprise.concurrent.spi(reflection mode)
    ******************************************************
******************************************************
arjantijms commented 3 months ago

Looks good. I do think that the java classes related to the signature test should be moved to a general lib in the TCK project, and not be duplicated (and enhanced) in each project separately. But that's outside the scope of this PR.