search

jakartaee / config

Jakartaconfig project
Apache License 2.0
21 stars 16 forks source link

Remove CDI dependencies #226

Closed radcortez closed 4 months ago

jansupol commented 4 months ago

I do not think the CDI tests should be dropped. They may be put into an optional profile, but the tests are useful when the implementation do support the CDI.

radcortez commented 4 months ago

It has to be removed because it would create a circular dependency between CDI and Config, assuming that we want to keep the goal of having Jakarta Config in the Core profile and have every other specification depend on it (including CDI to configure itself).

I think a better alternative is when CDI adopts Config, the requirements, and TCKs should be added in the CDI specification directly. Or in the Core Profile Specification.

Emily-Jiang commented 4 months ago

We can create a separate module to store these kind of tests, build a separate jar and it will be much easier to move later.

radcortez commented 4 months ago

We can still do all the CDI work and move it later to the CDI spec or Core profile spec, as long as the Config specification and resulting binaries do not reference CDI in any way.

jansupol commented 4 months ago

The Config dependency can be in the provided scope and picked up with CDI

Emily-Jiang commented 4 months ago

We agreed to put the tests in the Jakarta EE core profile for these kind of integration tests when we are ready to put up for a release.