search

jakartaee / expression-language

Jakarta Expression Language
https://eclipse.org/ee4j/el
Other
69 stars 50 forks source link

[JBEE-249] Catch the NoClassDefFoundError and add to the notAClass co… #107

Closed jamezp closed 4 years ago

jamezp commented 4 years ago

…llection for cases where the OS may have case-insensitive paths.

Signed-off-by: James Perkins jperkins@redhat.com

This came up on https://issues.jboss.org/browse/JBEE-249 and seems to affect Windows only with wildcard imports. I've not been able to test this on this default implementation, but it seems it could be an issue here so we thought an upstream fix would be good. Please let me know if further details are need.

Reproducing on Windows is quite easy with a JSP.

scottmarlow commented 4 years ago

+1

markt-asf commented 4 years ago

The comment in the patch is wrong. Windows is a case-insensitive file system. The original Java bug gets this right. The comment needs to be fixed.

jamezp commented 4 years ago

Ah you're correct that was a typo on my part @markt-asf. I'll get that fixed.

markt-asf commented 4 years ago

Thanks for the PR - and the quick response to the feedback.