search

jakartaee / expression-language

Jakarta Expression Language
https://eclipse.org/ee4j/el
Other
62 stars 49 forks source link

change from javax.* to jakarta.* #108

Closed scottmarlow closed 4 years ago

scottmarlow commented 4 years ago

Initial changes for javax. to jakarta. package rename. Where should we share changes like this? Perhaps via an EE9 or EE4J_9 branch?

FYI, planning for Jakarta EE 9 is not yet complete, but I think that some might want to start working on potential changes. I'm sharing this, so such (pre planning) efforts could use it.

Signed-off-by: Scott Marlow smarlow@redhat.com

arjantijms commented 4 years ago

Hi Scott, there have been some different discussions about where things should go. At least for Jakarta EE 8 many specs (but not all) did their work in the master branch, as that is representing the main version going forward.

markt-asf commented 4 years ago

+1 to working in master. In the unlikely event we need to do something for Jakarta EE 8, we can branch from the tag and work form there.

arjantijms commented 4 years ago

I'd also like to see the inserts of ELUtil. ... in a separate commit

If there's no explicit reason to insert those ELUtil. prefixes, we might as well leave them out. I guess some automatic tool might have added them?

scottmarlow commented 4 years ago

I used intellij to make the changes, not sure why trailing spaces were deleted yet, will figure that out or make the change again without intellij. I'm also not sure about the ElUtil issue, easy to fix that manually.

scottmarlow commented 4 years ago

I added a TODO to api/src/main/java/jakarta/el/ExpressionFactory.java, as the javax.el in properties should probably change also.

Disabling the Intellij EditorConfig plugin, helped avoid the removal of trailing spaces. I made the package changes again and pushed.

markt-asf commented 4 years ago

I agree the property name in ExpressionFactory needs to change as well. I thought about keeping javax.el.ExpressionFactory as a fall-back but, because of the package change, the implementations won't be compatible so I don't think there is any point in doing so. I've only looked at the API, not the impl.

scottmarlow commented 4 years ago

I pushed some property name changes, jakarta.el.bc2.2 replaced javax.el.bc2.2 and added javadoc for the ExpressionFactoryImpl#coerceToType that mentions the jakarta.el.bc2.2 property.

scottmarlow commented 4 years ago

Should we bump the spec version number to 4.0? If not, I'll update the last commit and squash that part of the change.