ValueExpression.getValueReference() sematics/bug

[glassfishrobot]

The class AstValue defines a method getValuereference(). The lower 'r' seems to be a typo and this method should probably be renamed to getValueReference() to override SimpleNode.getValueReference(). As a consequence, ValueExpression.getValueReference() currently returns null for expressions like #

{foo}

.

Furthermore, semantics of ValueExpression.getValueReference() are not entirely clear. Consider expression #

{foo.bar}

. What is the expected result of ValueExpression.getValueReference() if foo evaluates to base null? Currently a PropertyNotFoundException is thrown in this case, whereas getValue() would return null. Please clarify.

Thanks, Christoph

Environment

Operating System: All Platform: All

Affected Versions

[current]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/uel-ri/issues/17
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot

[glassfishrobot]

@glassfishrobot Commented Reported by beckchr

[glassfishrobot]

@glassfishrobot Commented beckchr said: Oops, the method is in AstIdentifier, not in AstValue...

[glassfishrobot]

@glassfishrobot Commented Was assigned to uel-issues

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA UEL-17

[markt-asf]

This was fixed at some point prior to the move to Eclipse (and we don;t have the history to figure out when).