Closed starksm64 closed 2 years ago
I can push it to central, but I'm just curious; why can't the downstream dependencies not update to 5.0.0 instead?
Nvm, 5.0.0 can't be pushed to central yet due to it not being approved yet. Maybe the current master should be staged as RC1 instead (being equal to 5.0.0), and that be pushed then.
RC1 (from https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/el/jakarta.el-api/5.0.0-RC1/) has been pushed to central.
And it already arrived there: https://repo1.maven.org/maven2/jakarta/el/jakarta.el-api/5.0.0-RC1/
This means we have an 5.0.0-RC1 release that is based of a later revision than the 5.0.0 version currently under release review. Is that wise?
I always wondered about this. If the release review passes, which is often against RC artefacts, we should be able to release a slightly newer version of the artefact to address small defects (like the copyright date change that was done).
Which exact revision was the staged 5.0.0 based upon?
I just checked, and this commit was not yet in 5.0.0 as staged:
But should we even release 5.0.0 without that?
It should be. The 5.0.0-RELEASE-api tag was made immediately after that commit. Are you looking at an out of date tag?
There isn't anything, yet, that I can see in the commit history post the 5.0.0 tag that would justify re-rolling 5.0.0. Of course, if the release review identifies any issues we'll need to re-roll 5.0.0 anyway.
It makes it awkward to have other releases pushed to maven central that have dependencies on EL which has no 5.0.x release out there. I'm not looking for a new release, just a release of an existing non-final 5.0.x release in staging released to central.
It should be. The 5.0.0-RELEASE-api tag was made immediately after that commit.
I downloaded the artefact from staging and its source jar had this in it:
/*
* Copyright (c) 2021 Contributors to the Eclipse Foundation
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the
* Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
* version 2 with the GNU Classpath Exception, which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
*/
module jakarta.el {
exports jakarta.el;
requires transitive java.desktop;
}
To be clear, I downloaded from https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/el/jakarta.el-api/5.0.0/
The date is "Mon Nov 08 20:06:16 UTC 2021"
Hmm. Something isn't right here. Time to do some digging.
Indeed, plus, the ballot for expression language hasn't started yet, has it?
The PR is still in progress, and the list at https://www.eclipse.org/lists/jakarta.ee-spec/2022/Jan/index.html doesn't mention any start of the ballot. It seems we should be good to still update and/or re-stage 5.0.0.
No not started yet as the PR is still in the review stage. https://github.com/jakartaee/specifications/pull/429
On Jan 19, 2022 at 10:07:21 AM, Arjan Tijms @.***> wrote:
Indeed, plus, the ballot for expression language hasn't started yet, has it?
— Reply to this email directly, view it on GitHub https://github.com/jakartaee/expression-language/issues/182#issuecomment-1016620083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRDMVA5SR5ZQ5TU5HRDF3UW3OTTANCNFSM5MIUIBNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Can't tell what went wrong as the CI build logs are long gone. I'll re-stage 5.0.0 now and then check it...
Mystery mostly solved. It appears that the CI build isn't dropping the existing staged even when configured to do so. Nexus shows the oldest version available in the file browser rather than the newest - hence we see the old version.
I've dropped the old staged versions and I'll look into why the CI build isn't doing what we expect.
Nexus shows the oldest version available in the file browser rather than the newest - hence we see the old version.
You're right, I just noticed that too. There were staged 5.0.0 versions.
I think that is the normal default behavior. You have to drop an existing release in order for the newer build to show up.
Based on the platform group discussion today, at least one of the milestones in staging should be made public so other downstream dependencies can make public releases. The latest milestone prior to the current 5.0.0 final was 5.0.0-M3: https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/el/jakarta.el-api/5.0.0-M3/
Could someone release that to maven central?