jakartaee / expression-language

Jakarta Expression Language
https://eclipse.org/ee4j/el
Other
67 stars 49 forks source link

Release to OSSRH staging repository #57

Closed m0mus closed 5 years ago

m0mus commented 5 years ago
markt-asf commented 5 years ago

The EE4J_8 branch is almost good to go as is the release build on Jenkins. We just need to update the license headers in master (#60 is waiting for an approval) and the apply the same change to the EE4J_8 branch. There are also some 'nice to have' clean-ups that we may or may not get to, time permitting.

markt-asf commented 5 years ago

The EE4J_8 branch is now good to go for the release build in Jenkins. I've just run the release build manually (build 25) and all looks good.

markt-asf commented 5 years ago

And I have now figured out how to get it to show up at: https://oss.sonatype.org/content/groups/staging/jakarta/el/jakarta.el-api/

vinayvishal commented 5 years ago

@markt-asf @m0mus , https://github.com/eclipse-ee4j/el-ri consists of both api and ri. Was there an ri release to staging too? As part of https://github.com/eclipse-ee4j/el-ri/issues/72, do we need to just integrate the api or ri as well. I don't basically see an ri release done for this.

markt-asf commented 5 years ago

That is news to me. I signed up to work on the API and the spec, not the implementation. I have no idea what state the RI code is in.

arjantijms commented 5 years ago

@vinayvishal

The EL project is one of those "special" projects. It contains a combined API + RI, and then hacks the API off of it. It's done in a pretty nasty way, but seemingly does work to some degree.

The coordinates of the combined jar are:

    <groupId>org.glassfish</groupId>
    <artifactId>jakarta.el</artifactId>
    <version>3.0.2</version>
senivam commented 5 years ago

EL-RI (RI) is released under:

https://oss.sonatype.org/content/groups/central-staging/com/sun/el/el-ri/3.0.2/

for RI mvn coordinates are

<groupId>com.sun.el</groupId>
    <artifactId>el-ri</artifactId>

thus the same as previous.

arjantijms commented 5 years ago

@senivam

That should not be correct.

The coordinates as announced in the release mail were org.glassfish:jakarta.el.

See: https://www.eclipse.org/lists/el-dev/msg00016.html

arjantijms commented 5 years ago

@senivam Additionally, the com.sun.el:el-ri coordinates were last used in 2008, and thereafter never since. See https://mvnrepository.com/artifact/com.sun.el/el-ri

arjantijms commented 5 years ago

@m0mus @senivam

After fixing the release script and re-running the script, it's now finally staged:

See: https://oss.sonatype.org/content/repositories/staging/org/glassfish/jakarta.el/3.0.2/

This is the artefact that corresponds to the recently released org.glassfish:javax.el See: https://mvnrepository.com/artifact/org.glassfish/javax.el

ricogu commented 5 years ago

Hi, team. Will this artifect v3.0.2 available in Maven central soon?