jakartaee / faces

Jakarta Faces
Other
102 stars 54 forks source link

Faces 4.0: rename "jsf" throughout source code to "faces" #1552

Closed BalusC closed 3 years ago

BalusC commented 3 years ago

"JSF" throughout source code must be renamed to "Jakarta Faces" or at least "Faces". No abbreviations.

For JavaScript:

For JNDI:

For passthrough elements:

For log strings:

For impl:

Doubts:

tandraschko commented 3 years ago

+1

BalusC commented 3 years ago

PR created in Mojarra project: https://github.com/eclipse-ee4j/mojarra/pull/4833

tandraschko commented 3 years ago

@BalusC FacesConfig.java still uses JSF

tandraschko commented 3 years ago

and what should we do about jsfc? just find a good name for it? maybe something like faces:component="h:outputText"

tandraschko commented 3 years ago

and +1 to delete PreJsf2ExceptionHandlerFactory

tandraschko commented 3 years ago

ResourceHandler also still contains "JSF_" vars i think we should rename all

BalusC commented 3 years ago
tandraschko commented 3 years ago

1) all right 2) it is ok for me but jsfc has a powerful feature to map e.g. "input" to "p:inputText". So one can use plain html and map them to PF via a single attribute. quite nice. 3) Really just deprecate PreJsf2ExceptionHandlerFactory? Never seens anyone uses it since 10 years JSF ;D 4) +1

arjantijms commented 3 years ago

it is ok for me but jsfc has a powerful feature

If I'm not mistaken, "jsfc" originally came in by accident. Both Mojarra and MyFaces essentially copied in Jackob's Facelet code, and it just had the "jsfc" attribute, even though it wasn't specified or anything.

Maybe if it becomes "component" we could take the opportunity to specify it better (if still needed).

BalusC commented 3 years ago
  1. We still need to retrofit @FacesConfig. Change API description, deprecate the Version, etc. Better create new ticket for focused discussion or reopen existing from manorrock.
  2. I'll leave it as-is for now. Better create new ticket for focused discussion.
  3. Alright, I'll just completely remove it! https://github.com/eclipse-ee4j/mojarra/pull/4907
  4. Done: https://github.com/eclipse-ee4j/mojarra/pull/4908
tandraschko commented 3 years ago

3 + 4 also fixed in MyFaces i think we can close this now

BalusC commented 3 years ago

:+1: