Closed jasondlee closed 2 years ago
Thanks for filing this. At a very quick glance it indeed looks like a valid challenge. Need a little bit more time to study it though.
As per TCK Process, after two weeks we should approve by lazy consensus (Approval by lazy consensus after a period of two weeks (14 days)
). Sound right to you @arjantijms?
If yes, I think we just need a pull request to exclude the challenged test and for that to be merged, verified and released.
@scottmarlow yes, nobody complained publicly, and I agree too. So we can go ahead and either remove or exclude the test in question.
Can we stage a 4.0.1 TCK via https://ci.eclipse.org/faces jobs? If the staged TCK looks good, we should publish it to https://download.eclipse.org/jakartaee/faces/4.0
@scottmarlow
Sure, I just staged it to
https://download.eclipse.org/faces/jakartaee10/staged/eftl/jakarta-faces-tck-4.0.1.zip
The staging job on the CI is
https://ci.eclipse.org/faces/job/1_faces-tck-build-and-stage/
Maybe I'm missing something. I'm trying to integrate this into our TCK build, but I'm running into build failures with this:
<dependency>
<groupId>org.glassfish</groupId>
<artifactId>jakarta.faces</artifactId>
<version>4.0.0-M7</version>
</dependency>
<dependency>
<groupId>jakarta.faces</groupId>
<artifactId>jakarta.faces-api</artifactId>
<version>4.0.1-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
Should that version be simply "4.0.0" and "4.0.1"? I modified the POM locally and the build seems happy...
Is this staged TCK bundle not ready for consumption? The contents/structure of this versus 4.0.0 we've been using (https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-faces-tck-4.0.0.zip) has also changed, making me wonder if I'm attempting to use the correct file. :)
@jasondlee a updated release of the TCK fixing some of the version issues was staged here:
https://download.eclipse.org/faces/jakartaee10/staged/eftl/jakarta-faces-tck-4.0.1.zip
It should be moved to the main download folder soon. Can you try with that one?
I'm seeing the same failure. If I download the archive, extract it, cd to faces-tck-4.0.1/tck and run
mvn -DskipOldTCK=true \
-DskipAssembly=true \
-Pwildfly-ci-managed \
-Dmojarra.version=$mojarraVersion \
-Dwildfly.dir=$WILDFLY_DIR \
-Daggregate=true \
clean \
install \
surefire-report:failsafe-report-only
I get
[ERROR] Failed to execute goal on project jakarta-faces-tck: Could not resolve dependencies for project org.eclipse.ee4j.faces.tck:jakarta-faces-tck:pom:4.0.1: The following artifacts could not be resolved: org.glassfish:jakarta.faces:jar:4.0.0-M7, jakarta.faces:jakarta.faces-api:jar:4.0.1-SNAPSHOT: org.glassfish:jakarta.faces:jar:4.0.0-M7 was not found in https://jakarta.oss.sonatype.org/content/repositories/staging during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of jakarta-staging has elapsed or updates are forced -> [Help 1]
Specification: Jakarta Faces 4.0 (EE 10) Standalone TCK
Challenged test(s): ee.jakarta.tck.faces.test.javaee7.cdimultitenantsetstccl.cdimultitenantsetstccl.Issue3341IT
TCK version: 4.0.0
Tested implementation: WildFly + Mojarra
Description: This test is exercising a flaw (now fixed) in a specific implementation, and is not actually testing any spec requirement.