search

jakartaee / faces

Jakarta Faces
Other
107 stars 55 forks source link

TCK Challenge: @Initialized/@Destroyed are not required by spec for FlowScoped/ViewScoped #1731

Closed brideck closed 1 year ago

brideck commented 1 year ago

Challenged Tests: ee.jakarta.tck.faces.test.javaee7.cdiinitdestroyevent.cdiinitdestroyevent.Issue2948IT#testFlowLogging ee.jakarta.tck.faces.test.javaee7.cdiinitdestroyevent.cdiinitdestroyevent.Issue2948IT#testViewScopedLogging

TCK Version: Jakarta Faces 4.0.x

Tested Implementation: Open Liberty -- containing MyFaces 4.0

Description: Section 2.5.7 of the CDI 4.0 specification states that "custom context implementations are encouraged to synchronously fire" events for @Initialized, @BeforeDestroyed, @Destroyed. Mojarra chose to implement this in https://github.com/eclipse-ee4j/mojarra/issues/2952, but MyFaces has not implemented this for the custom FlowScoped and ViewScoped scopes.

As the specification only encourages this and does not require it, it should not be tested in the TCK. If Faces would like this to be a requirement, it should be included in a future version of the specification.

tandraschko commented 1 year ago

Imo we should implement it in MyFaces

arjantijms commented 1 year ago

Imo we should implement it in MyFaces

Thanks, I create a spec issue to track it here: https://github.com/jakartaee/faces/issues/1739