search

jakartaee / faces

Jakarta Faces
Other
109 stars 55 forks source link

Missing "if" attribute of <f:viewAction> #1811

Closed FabriSr closed 1 year ago

FabriSr commented 1 year ago

The "if" attribute of is missing from Javadoc and VDLDoc.

BalusC commented 1 year ago

It's in javadoc of setter: https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/component/uiviewaction#setRendered(boolean), but it's indeed missing in getter.

The attribute description in vdldoc is completely correct, it's speaking as if it's the if attribute, however the attribute name is still mistakenly rendered.

See PR ^^

BalusC commented 1 year ago

cc: @tandraschko it has been merged now

tandraschko commented 1 year ago

currently it seems that MyFaces does not generate a taglib.xml this is a bigger task

i will create a new task on our side

feel free to close here

BalusC commented 1 year ago

At least javadoc of UIViewAction has to be adjusted.

volosied commented 1 year ago

@tandraschko

Does MyFaces need to generate the taglib.xml? What exactly is left here to be done here?

tandraschko commented 1 year ago

I think so But thats nothing spec related I created a MF issue

BalusC commented 1 year ago

Ok

volosied commented 9 months ago

@tandraschko

MyFaces Docs show rendered, not if: image

tandraschko commented 9 months ago

@volosied no idea, just checked the code itself currently i dont have many time to work on MF

volosied commented 8 months ago

https://github.com/apache/myfaces/pull/678