search

jakartaee / faces

Jakarta Faces
Other
109 stars 55 forks source link

Missing module-info.java leading to nasty warnings from compiler plugin #1815

Closed lprimak closed 8 months ago

lprimak commented 1 year ago

The module info file is missing from Faces API Jar, leading to issues with modularized applications:

[WARN] *****************************************************************************************************************************************************************************************************
[WARN] * Required filename-based automodules detected: [jakarta.faces-api-4.0.1.jar]. Please don't publish this project to a public artifact repository! *
[WARN] *****************************************************************************************************************************************************************************************************
arjantijms commented 1 year ago

Thanks for reporting. This is a bug, and the module-info should have been there.

lprimak commented 9 months ago

Hey Arjan, can this be fixed before Jakarta EE 11 please? Thank you!

lprimak commented 9 months ago

As of jakarta.faces-api-4.1.0-M1.jar this issue is not fixed yet...

arjantijms commented 9 months ago

Thanks for the reminder! This should absolutely be fixed for the upcoming (few days at most) M2 release.

arjantijms commented 8 months ago

@lprimak If you want, please look at https://github.com/jakartaee/faces/pull/1903

Would be great if you test it with your code.

lprimak commented 8 months ago

I’ll try

lprimak commented 8 months ago

Is there a pre-build JAR I can use?

arjantijms commented 8 months ago

Is there a pre-build JAR I can use?

Nope, the faces repo doesn't have builds for PRs enabled. Best would be to just build it yourself for now.

lprimak commented 8 months ago

I cannot build due to missing API dependencies, that are not in the Eclipse SNAPSHOT repository either. Any help appreciated, as there are way too many APIs to build on my own (basically all of core + web APIs) :)

BalusC commented 8 months ago

I was also facing that annoying problem. All I did was to just locally revert the API versions in pom.xml to the ones actually available in central.

arjantijms commented 8 months ago

Did you try building with -Pstaging?

All the dependencies should be in staging.

lprimak commented 8 months ago

ah! I tried with snapshot. I will try with staging

lprimak commented 8 months ago

It works. Requires changing requires from jarkarta.faces.api to jakarta.faces and it works correctly. Both compilers, deploys and runs! No warnings.

Thank you!