search

jakartaee / faces

Jakarta Faces
Other
109 stars 55 forks source link

Unify NavigationHandler and ConfigurableNavigationHandler #1833

Closed tandraschko closed 2 months ago

tandraschko commented 1 year ago

why was it introduced? backward compatibility?

BalusC commented 1 year ago

Looks like so. A whole new class for this doesn't seem to be necessary. It could have implemented default behavior. E.g. simply returning null or delegating to existing method or throwing UnsupportedOperationException.

tandraschko commented 1 year ago

Yep exactly

tandraschko commented 5 months ago

I moved now all methods from ConfigurableNavigationHandler to NavigationHandler and marked ConfigurableNavigationHandler + Wrapper als Deprecated

tandraschko commented 5 months ago

https://github.com/apache/myfaces/commit/f06506b5d644539080507f29667e4e0f8de86cdb

tandraschko commented 5 months ago

should we make the abstract methods just return null or empty collection?

tandraschko commented 4 months ago

fixed backward compatibility with PF: https://github.com/apache/myfaces/commit/edb58a9f41a7bd3a891bc596a40226e2d3178920