jakartaee / faces

Jakarta Faces
Other
103 stars 55 forks source link

JSF 2.3 Challenge: Failing Resource Tests in TCK (Revisit) #1976

Open volosied opened 2 weeks ago

volosied commented 2 weeks ago

Challenged Tests:

com.sun.ts.tests.jsf.api.javax_faces.application.resource.URLClient

com.sun.ts.tests.jsf.api.javax_faces.application.resourcewrapper.URLClient

TCK Version: JSF TCK 2.3.0

Tested Implementation: Open Liberty with MyFaces 2.3.11-SNAPSHOT

Description: The 4.0 TCK updated these tests as they were originally incorrect, as BalusC has pointed out in issue 1663. Links to the original issue and PR are posted below.

Can these tests be updated? It should be fairly simple to back port PR 1665.

References: Issue: https://github.com/jakartaee/faces/issues/1663

PR: https://github.com/jakartaee/faces/pull/1665

Thank you

BalusC commented 1 week ago

We don't have TCK for JSF 2.3. We only have TCKs for Faces versions since Eclipse transfer. During the Oracle era, all TCKs were closed source.

cc: @arjantijms (how do we best salvage this? is that at all possible?)

volosied commented 2 days ago

Please let me know. If the tests can be excluding (without code changes), or some other option.

Worse case, we can revert the changes in MyFaces to get the TCK to pass again -- no one has seemed to complain about this behavior so far.