Ajax Response Handling - View State / Body

eclipse-faces-bot commented 15 years ago

This request actually came in from the myfaces folks who are implemented a jsf 2 ajax solution (following spec):

When developing the AJAX part of MyFaces 2.0 we encountered 2 locations within the jsdoc part of the spec we'd propose for enhancement.

The first is about the hidden inputs for view state: The jsdocs for jsf.ajax.response imply that each hidden input receives the id "javax.faces.ViewState" which would result in multiple hidden inputs with this id in a multi form document. This is how Mojarra is currently working things out, but other implementations should get a chance to use a w3c conformant approach - the hidden inputs don't need ids at all, but only name=javax.faces.ViewState. A comment on this was already posted by Werner Punz.

The second is about replacing the body section of a document if the server sends the id javax.faces.ViewRoot: The jsdocs for jsf.ajax.response say that the impl should >>extract the contents of the element from the element's CDATA content and replace the document's section with this contents<<. According to this the attributes of the body element wouldn't be replaced with the new attributes, which probably isn't the intended behaviour. Preserving the attributes can either be achieved by copying them or by using contextualRagen/adjacentHTML instead of innerHTML.

Here is a proposal for changing the jsdocs for jsf.ajax.response to enable both enhancements mentioned above - please correct the jsdoc for jsf.ajax.response(request, context) like this:

If an update element is found in the response with the identifier javax.faces.ViewRoot:

Update the entire DOM as follows:

Extract the CDATA content and trim the and from the CDATA content if it is present.

<<<<<<< (remove the following lines)

If the CDATA content contains a element, and the document has a section, extract the contents of the element from the element's CDATA content and replace the document's section with this contents.
If the CDATA content contains a element, and the document has a section, extract the contents of the element from the element's CDATA content and replace the document's section with this contents.

======= (add the following lines)

If the CDATA content contains a element, and the document has a section, replace the document's section with the section contained within the CDATA content.
If the CDATA content contains a element, and the document has a section, replace the document's section with the section contained within the CDATA content.

If the CDATA content does not contain a element, replace the document's section with the CDATA contents.

If an update element is found in the response with the identifier javax.faces.ViewState:

Include this state in the document as follows:

Extract this element's CDATA contents from the response.

<<<<<< (remove the following lines)

If the document contains an element with the identifier javax.faces.ViewState replace its contents with the CDATA contents.
For each
element in the document: o If the element contains an element with the identifier javax.faces.ViewState, replace the element contents with the element's CDATA contents. o If the element does not contain an element with the identifier javax.faces.ViewState, create an element of the type hidden, with the identifier javax.faces.ViewState, set its contents to the element's CDATA contents, and add the element as a child to the element.

======= (add the following lines)

Set the value of all elements within the document with the name javax.faces.ViewState to the CDATA contents
Perform the following optionally, implementations my omit this to enhance performance, as it enforces a search within the DOM tree. For each element in the document: o If the element does not contain an element with the name javax.faces.ViewState, create an element of the type hidden, with the name javax.faces.ViewState, set its value to the element's CDATA contents, and add the element as a child to the element.

Best Regards, Ganesh Jung

Environment

Operating System: All Platform: Macintosh

Affected Versions

[2.0]

eclipse-faces-bot commented 5 years ago

Issue Imported From: https://github.com/javaee/javaserverfaces-spec/issues/552
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: Unassigned

eclipse-faces-bot commented 15 years ago

@glassfishrobot Commented Reported by rogerk

eclipse-faces-bot commented 15 years ago

@glassfishrobot Commented rogerk said: Created an attachment (id=224) changes

eclipse-faces-bot commented 15 years ago

@glassfishrobot Commented @edburns said: Move to unscheduled target milestone