UIRepeat et al are not specified

[eclipse-faces-bot]

with JSF 2.0, thanks to Facelets, there is a . While I understand that tags/rendering behavior is part of the internals of an implementation, I am not really sure if the underlying/related components should be "hidden" by the spec as well.

For instance: I noticed that in MyFaces the UIRepeat extends UIComponentBase and implements NamingContainer, while with the JSF RI / Mojarra, the UIRepeat "just" extends the UINamingContainer...

... and oh yes... I know that UINamingContainer extends UIComponentBase and implements NamingContainer....

but instanceof UINamingContainer doesn't say TRUE for the MyFaces UIRepeat

See a community related discussion here: http://markmail.org/message/wllfudu4ge7n5gxa

Environment

Operating System: All Platform: All

Affected Versions

[2.0]

[eclipse-faces-bot]

• Issue Imported From: https://github.com/javaee/javaserverfaces-spec/issues/704
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: Unassigned

[eclipse-faces-bot]

@glassfishrobot Commented Reported by mwessendorf@java.net

[eclipse-faces-bot]

@glassfishrobot Commented @edburns said: cat2

[eclipse-faces-bot]

@glassfishrobot Commented @edburns said: javadoc

[eclipse-faces-bot]

@glassfishrobot Commented @edburns said: These are targeted at 2.1.

[eclipse-faces-bot]

@glassfishrobot Commented @edburns said: rogerk

[eclipse-faces-bot]

@glassfishrobot Commented rogerk said: triage

[eclipse-faces-bot]

@glassfishrobot Commented @edburns said: https://glassfish.dev.java.net/issues/show_bug.cgi?id=11785

On Mon Apr 12 15:57:00 +0000 2010, mohammadalavi MA wrote

MA> I've found 2 bugs in jsf 1.2 here's the list MA> MA> MA> 1.when h:dataTable's parent is ui:repeat from facelet duplicated ids MA> are generated for child component because UIData's MA> isNestedWithinUIData method reports true MA> only when the parent is an instance of UIData and UIRepeat is not. MA> of course the problem happens because the UIData's getClientId method MA> caches the parent client id when isNestedWithinUIData returns false MA> if it never cache parent client id this problem wont happen. MA> MA> public String getClientId(FacesContext context) { MA> if (context == null)

{ MA> throw new NullPointerException(); MA> }

MA> if (rowIndex >= 0)

{ MA> String cidBuilder = new StringBuilder(); MA> return cidBuilder.append(super.getClientId(context)) MA> .append(NamingContainer.SEPARATOR_CHAR).append(rowIndex) MA> .toString(); MA> }

else

{ MA> return super.getClientId(context); MA> }

MA> } MA> 2.TableMetaInfo a static inner class in BaseTableRenderer is used for MA> managing style for columns and rows, the getCurrentColumnClass method MA> doesn't work as expected it doesn't repeat the styles when number of MA> columns is grater than column classes it should be implemented as MA> follows: MA> MA> public String getCurrentColumnClass() { MA> MA> String style = null; MA> if (columnStyleCounter < columnClasses.length && MA> columnStyleCounter < columnCount)

{ MA> style = columnClasses[columnStyleCounter++]; MA> }

MA> if(columnStyleCounter >= columnClasses.length)

{ MA> columnStyleCounter = 0; MA> }

MA> return ((style != null && style.length() > 0) ? style : null);

[eclipse-faces-bot]

@glassfishrobot Commented rogerk said: triage

[eclipse-faces-bot]

@glassfishrobot Commented rogerk said: triage

[eclipse-faces-bot]

@glassfishrobot Commented @edburns said: Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

[eclipse-faces-bot]

@glassfishrobot Commented This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-704