search

jakartaee / interceptors

Jakarta Interceptors
https://eclipse.org/ee4j/interceptors
Other
11 stars 24 forks source link

More precise language for InvocationContext.getInterceptorBindings() #103

Closed Ladicek closed 9 months ago

Ladicek commented 1 year ago

When I was working on the TCK tests for InvocationContext.getInterceptorBindings() (https://github.com/jakartaee/cdi-tck/pull/479), I realized there are some "interesting" cases that the previous specification didn't exactly cover well (allowed multiple interpretations). In this PR, I'm trying to tighten up the language to be precise.

manovotn commented 1 year ago

Also CC @arjantijms for committer review :)

arjantijms commented 1 year ago

LGTM, I do wonder if the specification text is still necessary when the javadoc already covers it. Though that's maybe a totally different discussion.

Ladicek commented 1 year ago

The reason why I basically copy the javadoc to the specification text is that the specification text should be complete. I generally like AtInject's approach that there is no other specification text than javadoc, but here, we have an extra specification text, and I feel like the best approach is to just duplicate the text.

manovotn commented 11 months ago

@arjantijms is there anything blocking this from getting merged?