jakartaee / interceptors

Jakarta Interceptors
https://eclipse.org/ee4j/interceptors
Other
11 stars 24 forks source link

Update Jakarta annotations API to newest version. #88

Closed manovotn closed 2 years ago

manovotn commented 2 years ago

There is a new release of jakarta annotations available, see https://repo1.maven.org/maven2/jakarta/annotation/jakarta.annotation-api/2.1.0-B1/

@arjantijms do you think it would be possible to get an Alpha/Beta release of interceptors with this? CDI is getting Jakarta annotations dependency transitively via interceptors API and we need some of those changes. Obviously, we can easily workaround this, but it wouldn't be as nice :-)

arjantijms commented 2 years ago

@manovotn This one slipped through, I'm going to do a 2.1-m1 release for interceptors now.

arjantijms commented 2 years ago

@manovotn After fumbling a little with the release scripts, it appeared the name had to be -RC1. It looks like Annotations slipped through since it still has the module check disabled in the spec-version-plugin.

Anyway, the staged release is now there:

https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/interceptor/jakarta.interceptor-api/2.1.0-RC1/

I didn't push it to Maven Central yet.

manovotn commented 2 years ago

Thanks. In the meantime, CDI explicitly declared dependency on annotations instead of inheriting it anyway.

However, I think @starksm64 said we still needed this release because of the (in)famousmodule-info?

starksm64 commented 2 years ago

@manovotn yes, we needed this 2.0.1 release in order to be able to add module-info to cdi-api without getting warnings about depending on automatic modules. Now we can do another Alpha/Beta with a module-info.