search

jakartaee / jakarta.ee

Jakarta EE is the future of cloud native Java. Jakarta EE open source software drives cloud native innovation, modernizes enterprise applications and protects investments in Java EE.
https://jakarta.ee
Eclipse Public License 2.0
158 stars 95 forks source link

Header Banner Missing #1717

Closed excentrickristy closed 9 months ago

excentrickristy commented 9 months ago

I noticed today that these two pages are missing the blue header banner: https://jakarta.ee/about/jesp/ https://jakarta.ee/committees/specification/guide/

While that is being fixed, could we add a global bottom margin to the inner pages header banner? Maybe 30 or 40px? I noticed that on many pages the content is getting very close to the banner:

image
excentrickristy commented 9 months ago

Also missing the header banner:

https://jakarta.ee/committees/specification/compatibility/ https://jakarta.ee/committees/specification/operations/ https://jakarta.ee/membership/join-us/ https://jakarta.ee/committees/specification/ https://jakarta.ee/community/developer-advocate/ https://jakarta.ee/committees/steering/brand_use_by_projects/ - this page is also missing the banner above the footer:

image
oliviergoulet5 commented 9 months ago

Thanks for the list of pages @excentrickristy.

Here is a preview of the header banners being added to the pages you listed:

The margin problem with the header banner occurred from a bug with missing breadcrumbs. I merged a patch which fixed the margins and the missing breadcrumbs.

However I could not reproduce the featured footer (the component with the "Register for EclipseCon 2023" text) problem you had. The background is an image so it is possible it wasn't loaded due to some network problem at the time. If it is still occurring, try to clear your cache with a hard refresh.

excentrickristy commented 9 months ago

They all look great except for https://deploy-preview-1721--jakartaee.netlify.app/community/developer-advocate/ - the banner is missing here still.

I agree, the footer issue must have been a glitch, looks good for me now!

oliviergoulet5 commented 9 months ago

Oh that's right, I forgot to mention the developer advocate page. It didn't appear to be a page in this repo when I was making the edits.

I'll take another look tomorrow.

In the mean time I'll put the current set of pages that you've reviewed into code review so we can push live.

oliviergoulet5 commented 9 months ago

All heading banners have been pushed live, with exception to the developer advocate page.

I haven't had the time to revisit the developer advocate page but I have not forgotten about it.

oliviergoulet5 commented 9 months ago

Here is a preview for the developer advocate page: https://deploy-preview-1724--jakartaee.netlify.app/community/developer-advocate/ @excentrickristy

excentrickristy commented 9 months ago

Looks good!