search

jakartaee / jakarta.ee

Jakarta EE is the future of cloud native Java. Jakarta EE open source software drives cloud native innovation, modernizes enterprise applications and protects investments in Java EE.
https://jakarta.ee
Eclipse Public License 2.0
158 stars 95 forks source link

Update Footer To Use Absolute Paths For Images #1925

Closed yashTEF closed 1 month ago

yashTEF commented 1 month ago

Changes relative paths in footer for images to absolute, for fragment/template usage.

netlify[bot] commented 1 month ago

Deploy Preview for jakartaee ready!

Name Link
Latest commit d5124c58d812ea382d24e77fde1bc09a93430644
Latest deploy log https://app.netlify.com/sites/jakartaee/deploys/665601a423e7df000811f465
Deploy Preview https://deploy-preview-1925--jakartaee.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yashTEF commented 1 month ago

@autumnfound , Could you review this?

So eclipse-ee4j/starter#293 can be closed.

autumnfound commented 1 month ago

@oliviergoulet5 if we want to use absolute URLs, the Hugo equivalent is {{ absURL "/images/jakarta/jakarta-ee-logo-white.svg" }}, correct? It's been a little while so I'm rusty and I want to confirm.

@yashTEF once I confirm the syntax, we should switch to this. We use preview links that allow us to have previews of functionality, so hard-coding the production host could lead to errors in previews if the assets ever change.

oliviergoulet5 commented 1 month ago

@autumnfound That's correct

yashTEF commented 1 month ago

@yashTEF once I confirm the syntax, we should switch to this. We use preview links that allow us to have previews of functionality, so hard-coding the production host could lead to errors in previews if the assets ever change.

Yes, I was confused too when I saw how urls were being referenced in the header/navbar.

Will change to this.