search

jakartaee / jakartaee-api

jakartaee-api
Other
39 stars 42 forks source link

update pom to create -sources.jar file for platform api #27

Closed kwsutter closed 5 years ago

kwsutter commented 5 years ago

Signed-off-by: Kevin Sutter kwsutter@gmail.com

kwsutter commented 5 years ago

Was it not creating the source jar during deployment? Is this just causing it to create the source jar during the package phase?

I had noticed it on my local system when I was building that the -sources.jar file was not getting created for the platform api. And, then when I looked at the artifacts on the jenkins job, it was not getting picked up. So, I got curious and looked and noticed that we were not generating the -sources.jar file for the platform api. But, we were for the webprofile api. Just trying to be consistent.

bshannon commented 5 years ago

The web profile one is generated because it's needed by the full platform. The full platform one is only needed when deploying to a Maven repository. I believe that's done by default as part of "mvn deploy".

We can generate the full platform source jar earlier if you really want, but I don't think it's necessary. I'll leave it up to you.

kwsutter commented 5 years ago

Thanks, Bill. Since I discovered it when I was looking at our nightly build job, I think I'll go ahead with this merge to make it available earlier in the process.