search

jakartaee / jakartaee-api

jakartaee-api
Other
39 stars 42 forks source link

Get jenkins working #58

Closed kwsutter closed 4 years ago

kwsutter commented 4 years ago

For some reason, the jenkins builds were not producing the proper -sources and -javadoc jar files for the build. Maybe this was due to some of the pom plugin dependencies that changed since version 1.0.5 of the parent pom. Not sure.

In any case, I found two configuration items that were required to properly produce and attach these two artifacts. After some experimenting, I then moved this configuration item to the jakartaee-api parent pom so that we only have it configured in one place.

I also removed the exclude of the rpc apis since they should no longer exist in the ejb api jar file. RPC is not part of the Jakarta EE 9 effort, so the jakarta/xml/rpc package would not exist.

For this effort, I also made a couple of modifications to the Jenkins "release" job (not under source control). One was to process the "BRANCH" parameter that defaulted to "master". With this change, you can now run the Jenkins build against a branch (ie. get-jenkins-working) while working through necessary updates. And, the other change was to remove the use of the release-phase2 and embedded Profiles on the mvn invocation. These Profiles do not exist with the build plugins we are using and are probably leftovers from Glassfish builds. These were causing innocuous warnings during the build.

After this PR is reviewed and merged, then I think we're ready to produce an RC1 of the Platform and Web Profile APIs.

kwsutter commented 4 years ago

For some reason, the jenkins builds were not producing the proper -sources and -javadoc jar files for the build. Maybe this was due to some of the pom plugin dependencies that changed since version 1.0.5 of the parent pom. Not sure.

I did figure out that the maven-enforcer-plugin was updated in Nov 2019, which was after we released Jakarta EE 8. So, that might explain why the lack of these files were not preventing the builds from succeeding in the past. Our parent pom doesn't specify a version for this plugin, so we would just pull the latest version for processing. I've opened a PR on the parent pom to clarify the desired versions for the enforcer, source, and javadoc plugins.