jakartaee / jakartaee-schemas

Other
7 stars 20 forks source link

Missing schema version updates #32

Open tbitonti opened 2 years ago

tbitonti commented 2 years ago

See pull request #15:

"Update Common shareable schemas from 9 to 10" https://github.com/eclipse-ee4j/jakartaee-schemas/pull/15

That created a new "jakartaee_10.xsd", which was propogated to the then present includes of "jakartaee_9.xsd".

There were a number of followup pull requests which renamed the schemas:

"Update Application Deployment Descriptor Schema for Jakarta EE 10" https://github.com/eclipse-ee4j/jakartaee-schemas/pull/19

"Update application client xml schema for Jakarta EE 10" https://github.com/eclipse-ee4j/jakartaee-schemas/pull/20

And others. However, not all of the schemas have been renamed:

connector_2_0.xsd jakartaee_web_services_2_0.xsd web-facelettaglibrary_3_0.xsd web-facesconfig_3_0.xsd

(Not needed: ejb-jar_4_0.xsd.)

This creates incompatible versions of these schemas, which have the old Jakarta EE 9 name and version, but have includes to Jakarta EE 10 schemas.

These remaining schemas need an updated version and need to be renamed.

tbitonti commented 2 years ago

Removing jakartaee_web_services_client_2_0.xsd from the list of schemas which must be updated. There are no changes (yet) to this schema. No includes are present which were updated.

tbitonti commented 2 years ago

Removing (for now) web-partialresponse_3_0.xsd from the list of schemas which must be updated. I can't tell what version should be used for this schema.

tbitonti commented 2 years ago

Based on the Jakarta EE 10 specification updates, these updates are proposed:

connector_2_0.xsd connector_2_1.xsd web-facesconfig_3_0.xsd web-facesconfig_4_0.xsd web-facelettaglibrary_3_0.xsd web-facelettaglibrary_4_0.xsd

Not needed: ejb-jar_4_0.xsd ejb-jar_5_0.xsd

Note: I'm not seeing a use of the new jakartaee_10.xsd schema elements. Is the update to the connector schema necessary? (Or, could someone identify the path within connector to the new elements?)

tbitonti commented 2 years ago

See pull request #33 "Adjusted schema versions; adjusted test data to match."

tbitonti commented 2 years ago

I'm not seeing a new web-services schema. I've removed web-services from the list of forced updates: web-facesconfig_2_0.xsd - web-facesconfig_4_0.xsd

ivargrimstad commented 2 years ago

Thanks for doing this. But please keep in mind that not all specs are updated for the EE 10 release, so there will be some EE 9 versions of schemas still there

tbitonti commented 2 years ago

Removing EJB. This was addressed by issue #34. EJB is not being updated. The new reference elements may not be used through EJB.

edburns commented 1 year ago

@ivargrimstad Can you please add the label jea-linked to this? I linked it to AB#163