jakartaee / jakartaee-schemas

Other
8 stars 20 forks source link

Use https for w3 locations #39

Open ivargrimstad opened 1 year ago

ivargrimstad commented 1 year ago

See https://github.com/jakartaee/jakarta.ee/issues/1505

scottmarlow commented 1 year ago

@ivargrimstad did you intend to update all xsd files or only EE 10 ones?

Output from grep -rli "http:.*www.w3.org" --include=*.xsd:

static/xml/ns/jaxws/wsdl_customizationschema_3_0.xsd
static/xml/ns/validation/validation-mapping-3.0.xsd
static/xml/ns/validation/validation-configuration-3.0.xsd
static/xml/ns/persistence/persistence_3_0.xsd
static/xml/ns/persistence/orm/orm_3_0.xsd
static/xml/ns/persistence/orm/orm_3_1.xsd
static/xml/ns/jaxb/bindingschema_3_0.xsd
static/xml/ns/jakartaee/web-app_6_0.xsd
static/xml/ns/jakartaee/web-partialresponse_3_0.xsd
static/xml/ns/jakartaee/batchXML_2_0.xsd
static/xml/ns/jakartaee/web-facelettaglibrary_3_0.xsd
static/xml/ns/jakartaee/ejb-jar_4_0.xsd
static/xml/ns/jakartaee/jakartaee_web_services_2_0.xsd
static/xml/ns/jakartaee/web-facelettaglibrary_4_0.xsd
static/xml/ns/jakartaee/application_9.xsd
static/xml/ns/jakartaee/connector_2_1.xsd
static/xml/ns/jakartaee/web-fragment_6_0.xsd
static/xml/ns/jakartaee/web-common_5_0.xsd
static/xml/ns/jakartaee/web-partialresponse_4_0.xsd
static/xml/ns/jakartaee/web-common_6_0.xsd
static/xml/ns/jakartaee/jakartaee_9.xsd
static/xml/ns/jakartaee/web-jsptaglibrary_3_1.xsd
static/xml/ns/jakartaee/web-facesconfig_4_0.xsd
static/xml/ns/jakartaee/application-client_9.xsd
static/xml/ns/jakartaee/web-facesconfig_3_0.xsd
static/xml/ns/jakartaee/beans_4_0.xsd
static/xml/ns/jakartaee/jakartaee_web_services_metadata_handler_3_0.xsd
static/xml/ns/jakartaee/web-jsptaglibrary_3_0.xsd
static/xml/ns/jakartaee/application-client_10.xsd
static/xml/ns/jakartaee/web-fragment_5_0.xsd
static/xml/ns/jakartaee/jsp_3_1.xsd
static/xml/ns/jakartaee/web-app_5_0.xsd
static/xml/ns/jakartaee/permissions_9.xsd
static/xml/ns/jakartaee/beans_3_0.xsd
static/xml/ns/jakartaee/connector_2_0.xsd
static/xml/ns/jakartaee/jobXML_2_0.xsd
static/xml/ns/jakartaee/jakartaee_web_services_client_2_0.xsd
static/xml/ns/jakartaee/application_10.xsd
static/xml/ns/jakartaee/jsp_3_0.xsd
static/xml/ns/jakartaee/permissions_10.xsd
scottmarlow commented 1 year ago

https://github.com/scottmarlow/jakarta.ee/commit/f091b53ffa85544f421db39c6e6cd11fe547e512 has just a static/xml/ns/jakartaee/jakartaee_10.xsd change but static/xml/ns/jakartaee/jakartaee_9.xsd also has a similar w3 http reference (and other files as well).

ivargrimstad commented 1 year ago

I started digging a little into this, and I am not so sure changing anything would actually help. The w3-schemas we are referencing have HTTP refs internally. And we are not allowed to change those. So we would essentially just be kicking the ball down one row...

pzygielo commented 1 year ago

I started digging a little into this

perhaps too deep

and I am not so sure changing anything would actually help. The w3-schemas we are referencing have HTTP refs internally. And we are not allowed to change those. So we would essentially just be kicking the ball down one row...

Just changing xsd:import/schemaLocation for example https://github.com/eclipse-ee4j/jakartaee-schemas/blob/c1178755c94725cc002732c25f5b601b6057a222/xml/src/jakartaee_10.xsds#L41-L42 actually helps (in my case), like in

No need to change namespaces or other references, but import instruction uses direct link to resource.

With above, grep -ri "http:.*www.w3.org" --include=*.xsd| grep schemaLocation only lists

xml/ns/jakartaee/jakartaee_9.xsd:              schemaLocation="http://www.w3.org/2001/xml.xsd"/>
xml/ns/jakartaee/jakartaee_10.xsd:              schemaLocation="http://www.w3.org/2001/xml.xsd"/>
ivargrimstad commented 1 year ago

Thanks @pzygielo That sounds doable. I'll get it done right away