Open kito99 opened 8 months ago
@markt-asf and @stuartwdouglas can you take a look at this in the next couple of days? I'd love to know (a) if this looks accurate for Jakarta EE 10 and (b) if you or someone on the team can make this change.
@jhammen this is a good candidate.
happy to work on this but it looks like there are some major changes to these sections still waiting in PR #36 @kito99 @BalusC do you think these changes are likely to be merged soon?
@jhammen I think the changes to that PR are good; @BalusC can you merge in main
and test the build (if you haven't already)?
Done. You can advance.
First example mentioned is "hello-servlet" which does not exist at the path given, looks like it was repaced with a "hello2" example which has similar code and an additional servlet. So the copy needs to be updated, code snippets should use the new code and links should point to the new example paths.
The "hello2" example does not appear to have any deprecated methods, works fine with tomcat:10.1.16
So the copy needs to be updated, code snippets should use the new code and links should point to the new example paths.
Please no. It's the other way round. hello1
and hello2
from previous tutorial versions have been replaced by hello-faces
and hello-servlet
via https://github.com/jakartaee/jakartaee-tutorial/pull/24/files
Surely the old ones will work fine but they expose outdated/bad practices these days.
I am aware that the tutorial examples needed to catch up this but then Eclipse's budget for the initial work ran out and I've higher priorities in my free time (OmniFaces and Jakarta Faces itself, for example). I do however have a complete rewrite of Jakarta Faces chapter of the EE10 tutorial in my mind. So please leave that to me if possible. Note that its original source, the Faces 4.0 spec, has already been rewritten by me ~2y ago: https://jakarta.ee/specifications/faces/4.0/jakarta-faces-4.0
Btw I would love to continue reviewing the servlet chapters because I also had a lot of improvements for these in my mind. The existing examples are horribly outdated.
I am aware that the tutorial examples needed to catch up
Oh wait. They were already created. The PR is simply still pending review/merge. https://github.com/eclipse-ee4j/jakartaee-examples/pull/80 The difficulty is that review/merge is beyond our control because repo is in different organization. As of now only @arjantijms can do that.
OK that all makes sense and I'm glad this already fixed pending PR.
@BalusC I don't want to get in the way if you have this update under control, I'm happy to step back. Did you want to assign me tickets for things you intended to do? Otherwise maybe @kito99 can assign other sections for me to work while I have the time to spare
Current ticket is only for "Jakarta Servlet" so that's completely fine :)
OK cool I'll continue, but maybe will wait until that PR is merged as I'm not sure it makes a lot of sense to review the examples before they are up to date
@jhammen you can update the text in the meantime if you want..
@jhammen you can update the text in the meantime if you want..
You're right - the 6.0 links are now added/updated, please see the above commit reflected here:
@jhammen it would also be nice to add a couple sentences about the new feature to get a UUID and other connection details for an incoming request to the https://jakartaee.github.io/jakartaee-documentation/jakartaee-tutorial/current/web/servlets/servlets.html#_getting_information_from_requests section. See https://github.com/jakartaee/jakartaee-tutorial/issues/91.
Current tutorial chapters for Servlet: https://jakartaee.github.io/jakartaee-documentation/jakartaee-tutorial/current/web/webapp/webapp.html
For background, here are the changes for Servlet 6.0:
The only change that may affect the tutorial is the removal of deprecated features.
Please do the following: