search

jakartaee / jaxb-tck

Other
4 stars 15 forks source link

javax-to-jakarta renames in source #27

Closed dblevins closed 4 years ago

dblevins commented 4 years ago

Again an attempt to be helpful, but not versed in this TCK so unsure if this will even build. Very open to direction on how to make this more actionable.

dblevins commented 4 years ago

@RohitKumarJain Note there are 8496 files that don't have 2020 in their copyright. I'm happy to fix all of them, but would prefer to do it in a separate PR.

dblevins commented 4 years ago

@RohitKumarJain here's the PR for copyrights https://github.com/eclipse-ee4j/jaxb-tck/pull/28

RohitKumarJain commented 4 years ago

@dblevins , I guess there is some confusion, "you don't need to modify all the files, which is not even updated in the current year."

The copyright date should include the year when the content was first created and published on the site. Since the contents are constantly evolving it is common practice to use a notice that includes both the original creation date and the most recent date in which content was added or modified.

So you only need to update the copyright year in the most recently updated files. Hope it clarifies the intention of my review comment.

RohitKumarJain commented 4 years ago

@dblevins , Would like to know if you are still facing any issue? If we are good then can you please update the copyright year in the mentioned files in the PR comment above, so that we can merge this PR. Thanks

gurunrao commented 4 years ago

@Tomas-Kraus is it possible to merge above PR. @RohitKumarJain will update copyright with new PR, once PR 27 is merged