search

jakartaee / jaxb-tck

Other
4 stars 16 forks source link

Remove tests covering JAXB 1.0 compatibility #63

Closed lukasj closed 2 years ago

lukasj commented 2 years ago

XMLB 4.0 completely drops compatibility with JAXB 1.0, related tests needs to removed as well, see https://github.com/eclipse-ee4j/jaxb-api/issues/186

gurunrao commented 2 years ago

@lukasj - among the tests here https://ci.eclipse.org/jakartaee-tck/job/jaxb-tck/job/master/112/testReport/ , which of them are JAXB 1.0 compatibility tests?

lukasj commented 2 years ago

that's a good question. Any idea what //TargetSpec[@Version] in the test descriptor means? What is the difference ie between values -1.0, 1.0 and 1.0-? Assuming 1.0 means that the test targets spec version 1.0, -1.0 version up to 1.0 and 1.0- targets spec version 1.0 and newer, I'd start by deleting everything related to 1.0, changing all other version numbers to 3.0- and see what fails for 3.0 API (I think no failures should be seen here and number of tests should hopefully remain the same, if not we need to evaluate what is going on) and 4.0-RC API.

Now the question is how to move from here. 4.0 removes jakarta.xml.bind.Validator, so if the test fails to compile, then it does not belong to 4.0. It also removes support for jaxb.properties, so if the test relies on this file then it should be either removed or updated.

By the test descriptor I mean ie https://github.com/eclipse-ee4j/jaxb-tck/blob/master/jaxb-tck/tests/schema2java/structures/SType/ST_facets/ST_facets00602/ST_facets00602_n.test.xml#L34

gurunrao commented 2 years ago

PR https://github.com/eclipse-ee4j/jaxb-tck/pull/65 has been merged to master.