search

jakartaee / jaxb-tck

Other
4 stars 16 forks source link

jaxb-tck JDK 11 build. #67

Closed gurunrao closed 2 years ago

gurunrao commented 2 years ago

issue:https://github.com/eclipse-ee4j/jaxb-tck/issues/64 CI run:https://ci.eclipse.org/jakartaee-tck/job/guru/job/jaxb-tck-guru/job/jdk11-build/ Signed-off-by: gurunandan.rao@oracle.com <gurunandan.rao@oracle.com

gurunrao commented 2 years ago

jakarta.activation.jar is going away (we may still produce it in the angus project if needed but getting rid of it is preferred); the build should use jakarta.activation-api.jar instead, should the implementation be needed, then angus-activation.jar is an option.

Since the build requires JDK 11 now, I prefer an update to start using module path where appropriate:

  • APIs are supposed to be proper modules in EE 10, therefore jakarta.*-api.jars should be passed to at least some java/javac/javadoc commands on the --module-path instead of the classpath
  • it may be required to add --add-modules ALL-MODULE-PATH to java/javac/javadoc command to force module resolution (it should be enough to use --add-modules jakarta.xml.bind, ALL is just safer option)

(see eclipse-ee4j/jaf-tck#34 for how it is done JAF-TCK)

I'm fine with addressing my comment in another PR if you prefer that

IMO, its better to open new PR to upgrade jakarta-activation-api.jar.

lukasj commented 2 years ago

IMO, its better to open new PR to upgrade jakarta-activation-api.jar.

OK