search

jakartaee / jaxb-tck

Other
4 stars 16 forks source link

#78: move from http to https for w3.org #80

Closed lukasj closed 1 year ago

lukasj commented 1 year ago

fixes #78 hopefully - @gurunrao or @scottmarlow are you able to verify this change somehow? another way to verify this change can be to edit files updated in this PR by hand in official 4.0.0 TCK binary (there should be no need to build the TCK to verify this change)

gurunrao commented 1 year ago

I have started CI run https://ci.eclipse.org/jakartaee-tck/job/guru/job/jaxb-tck-guru/job/pull-80/3/ for the PR.

scottmarlow commented 1 year ago

I'll try this locally.

Any suggestions for how to run a specify test folder? With ant I always changed into the test folder before doing a ant runclient. Is there a configuration.jti setting or command line option passed into -runtests (javatest.jar) command?

lukasj commented 1 year ago

I don't know, sorry. I haven't had to run one particular test - or subset of tests if that matters - in the past. On rare occasions it was enough for me to extract the failure into simple java/xml/xsd file to fix the problem on the CI side.

lukasj commented 1 year ago

reading https://github.com/eclipse-ee4j/jaxb-tck/issues/78#issuecomment-1245500725 again - it looks like http://www.w3.org/2005/05/xmlmime will have to be updated to https as well. Let's see if this particular change improves things first..

scottmarlow commented 1 year ago

reading #78 (comment) again - it looks like http://www.w3.org/2005/05/xmlmime will have to be updated to https as well. Let's see if this particular change improves things first..

Which references to http://www.w3.org/2005/05/xmlmime need to change for those tests? I don't see references directly in the failing tests to http://www.w3.org/2005/05/xmlmime unless I missed something.

Or in the XmlMimeType handling in the implementations like https://github.com/eclipse-ee4j/jaxb-ri?

scottmarlow commented 1 year ago

In case it helps, I started https://github.com/scottmarlow/jaxb-ri (fork of https://github.com/eclipse-ee4j/jaxb-ri) to update http://www.w3.org/2005/05/xmlmime references in there to https. I'll try some testing of that change.

scottmarlow commented 1 year ago

https://github.com/eclipse-ee4j/jaxb-ri/pull/1661 seems to resolve the 16 XML Binding TCK failures with WildFly.

lukasj commented 1 year ago

this did not help/is wrong