search

jakartaee / jaxb-tck

Other
4 stars 16 forks source link

exclude test for combination of 'length' and 'minLength' facets #83

Closed lukasj closed 8 months ago

lukasj commented 8 months ago

exclude jdk version dependent tests - fixes #82

@gurunrao can you review and double-check this, please?

scottmarlow commented 8 months ago

@gurunrao is https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-jaxb-tck-build-run-100 where we should build the XML Binding TCK with this change once merged?

gurunrao commented 8 months ago

@lukasj - I have started CI build https://ci.eclipse.org/jakartaee-tck/job/guru/job/jaxb-tck-guru/job/is82/2/ for verification of exclusion. Post completion of build, we can manually verify if test has run or excluded.

gurunrao commented 8 months ago

@gurunrao is https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-jaxb-tck-build-run-100 where we should build the XML Binding TCK with this change once merged?

We have to run the build https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-jaxb-tck-build-run-100 post update of Version number, else the Job will over-write existing staged xml-binding tck.

lukasj commented 8 months ago

post update of Version number, else the Job will over-write existing staged xml-binding tck.

see #84

lukasj commented 8 months ago

rebased on master so this gets the correct version number

lukasj commented 8 months ago

the test job did not run affected tests, so this is OK