search

jakartaee / jekyll-theme-jakarta-ee

This theme is currently experimental, but intended to provide the branding for Jakarta EE projects using GitHub pages for their documentation.
https://jakartaee.github.io/jekyll-theme-jakarta-ee/
Eclipse Public License 2.0
4 stars 14 forks source link

Release current version of the theme and publish on RubyGems #17

Closed chrisguindon closed 5 years ago

chrisguindon commented 5 years ago

Signed-off-by: Christopher Guindon chris.guindon@eclipse-foundation.org

chrisguindon commented 5 years ago

@jgallimore,

I am currently working on a PR to resolve the deployment issue on RubyGems. I was thinking of naming the gem "eclipsefdn-jekyll-theme-jakarta-ee" to be consistent with what we do on NPM: https://www.npmjs.com/package/eclipsefdn-hugo-solstice-theme

Would you prefer to keep it the same name as the repo "jekyll-theme-jakarta-ee"?

If we do change it, I assume that I will need to rename and update the spec.name property for the jekyll-theme-jakarta-ee.gemspec file.

chrisguindon commented 5 years ago

Hi @jgallimore ,

do you have a preference here?

If you think this rename will cause some extra work, I can revert some of my change and deploy the gem as jekyll-theme-jakarta-ee.

jgallimore commented 5 years ago

No strong opinion on the name here, but there's at least 2 projects, using it now (maybe more), so we need to be a little careful there. If we don't keep the repo name, I think we'll be ok in that respect.

Is having an API key in the source code secure?

chrisguindon commented 5 years ago

@jgallimore,

Thanks for the feedback! +1 for not breaking anything. I will try to deploy the gem using the name of the repo.

The api keys are encrypted: https://docs.travis-ci.com/user/environment-variables/#defining-encrypted-variables-in-travisyml

chrisguindon commented 5 years ago

jekyll-theme-jakarta-ee@0.1.2 has been pushed to rubygems.org: https://rubygems.org/gems/jekyll-theme-jakarta-ee

chrisguindon commented 5 years ago

@jgallimore If you prefer, I can remove the api_key and from .travis file and add it via the travis-ci configuration page.

I did notice that the travis gem does the same thing: https://github.com/travis-ci/travis.rb/blob/master/.travis.yml