search

jakartaee / jsonb-api

Jakarta JSON Binding
https://eclipse-ee4j.github.io/jsonb-api/
Other
78 stars 39 forks source link

UntypedMappingTest.testArrayMapping fixed #275

Closed Verdent closed 3 years ago

Verdent commented 3 years ago

Fixes #267

rmannibucau commented 3 years ago

@Verdent runtimeType usage is undefined in https://github.com/eclipse-ee4j/jsonb-api/blob/master/api/src/main/java/jakarta/json/bind/Jsonb.java so I assume it is not a portable behavior as of today. While I'm not against this PR I think the Jsonb javadoc must be fixed before relaxing the TCK in such a manner. Since 3.17.1 point of the spec is about "may" and not "must" then I guess we should mainly just add to the javadoc the constraint and keep the spec as this (without strong requirement for now) to get a quick acceptable fix (specifying strongly the resolution will be a lot of work since it is not always trivial to be complete so i'd keep it relaxed for now to not reduce the implementators scope). Hope it makes sense.