search

jakartaee / mail-api

Jakarta Mail Specification project
https://jakartaee.github.io/mail-api
Other
240 stars 100 forks source link

Test failure with java-21 on LogManagerPropertiesTest #700 #704

Closed jmehrens closed 5 months ago

jmehrens commented 5 months ago

Signed-off-by: jmehrens jason_mehrens@hotmail.com

jmehrens commented 5 months ago

Summary of changes:

  1. This is a backport of https://github.com/eclipse-ee4j/angus-mail/pull/117
  2. Limitations are JDK7 support so no use of java.util.Objects, lambdas, or diamond operator in anonymous classes.
  3. Logger.getGlobal is not used to support GAE and Android.
  4. I removed trailing whitespace and that makes AbstractLogging look like everything changed. The only really change was updating the copywrite and porting of the comment from the original PR.
  5. Fixed a benign NPE in LogManagerProperties that was reported by SpotBugs.
vaukai commented 5 months ago

Summary of changes:

1. This is a backport of [Remove SecurityManager references from logging package #16 eclipse-ee4j/angus-mail#117](https://github.com/eclipse-ee4j/angus-mail/pull/117)

2. Limitations are JDK7 support so no use of java.util.Objects, lambdas, or diamond operator in anonymous classes.

3. Logger.getGlobal is not used to support GAE and Android.

4. I removed trailing whitespace and that makes AbstractLogging look like everything changed.  The only really change was updating the copywrite and porting of the comment from the original PR.

5. Fixed a benign NPE in LogManagerProperties  that was reported by SpotBugs.

Thank you very much for fixing it. On Gentoo we are however getting the same test failure with jakarta-mail-2.0.1. Could this please also be fixed? Would it need a separate bug report?

jmehrens commented 5 months ago

The v1.x branch is JavaMail 1.6.8 snapshot. Ever since JakartaMail 2.1.0 the offending code has been moved to Angus Mail. This issue is a backport from current Angus Mail snapshot. You'll need to upgrade to a later Jakarta Mail release when we publish it.