Updated pom files - Githubissues

jakartaee / messaging

Jakarta Messaging

https://eclipse.org/ee4j/messaging

Other

39 stars 32 forks source link

Updated pom files #256

Closed arjantijms closed 4 years ago

arjantijms commented 4 years ago

Set API version to x.y.z
Update plugin versions
Update spec plugin
Deabstract abstractions that are only used once
Ordered poms according to Maven default order

Signed-off-by: arjantijms arjan.tijms@gmail.com

arjantijms commented 4 years ago

It's hard to tell but it looks like the entire pluginManagement section was removed and the version information spread out to the plugin configuration sections. My understanding is that it is still a best practise to manage all the version numbers in the pluginManagement section in the top level pom, even if each plugin is only used once.

I did this to be consistent with the other API projects. As far as I could see, only JMS did it this way. I simply opened the other pom files and made them as must alike as feasible.

arjantijms commented 4 years ago

Also, it looks like a bunch of spec-version-maven-plugin configuration was removed and I'm not sure what the impact of that is. Was it all unused? Or is less checking being done now?

That was all related to the specific process of releasing intermediate releases under the JCP, with specific early builds etc. As none of the other spec projects use this, and it's not in any of the Jakarta version documents, I removed this to be consistent.

arjantijms commented 4 years ago

I'll leave it to you to decide how to address my comments...

Thanks!