Repeatable annotation for the connection factory and destination definition annotations - fix for #151

jakartaee / messaging

Jakarta Messaging

https://eclipse.org/ee4j/messaging

Other

39 stars 32 forks source link

Repeatable annotation for the connection factory and destination definition annotations - fix for #151 #298

Closed nderwin closed 3 years ago

nderwin commented 3 years ago

added the Repeatable annotation for the connection factory and destination definition annotations
possible fix for #151

Signed-off-by:Nathan Erwin nathan.d.erwin@gmail.com

OndroMih commented 3 years ago

It really looks this is all that's needed. There's no mention about these annotations in the spec document.

dblevins commented 3 years ago

Note we do have TCK updates to do when modifying APIs:

The signature files will need to be regenerated so the signature tests don't fail.
We should also add a TCK test that uses the annotation repeatably and verifies the vendor supports it. For that we can most likely find the test that uses JMSDestinationDefinitions and copy/modify it (hopefully there is a test that uses that annotation meaningfully).

nderwin commented 3 years ago

@dblevins If you'll point me at the TCK, I can look into making a PR there too. I'd feel better having a test for this there too.

OndroMih commented 3 years ago

@nderwin, with the TCK it's not that easy. The Messaging TCK is a part of the Jakarta EE TCK. We're going to separate it away into the Messaging project, either into this repository or into a new repository. I think it's better to wait until we do it, as we may also modernize the TCK so that it's easier to work with it. The current TCK is based on the Java Harness test framework, which is not very convenient nowadays.

dblevins commented 3 years ago

@nderwin Sounds great, Nathan. Thanks for volunteering! Fair warning the TCK is still one large suite covering all (most) specs, so it will be hard to digest and if you get anywhere you'll be one of only a handful who can grok it. That said, it's what we got, LOL :)

Here is the section where the JMS tests are located:

https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jms

The best resource for help:

https://accounts.eclipse.org/mailing-list/jakartaee-tck-dev

Here's a similar PR for when we made EJBs @Schedule annotation repeatable.

https://github.com/eclipse-ee4j/jakartaee-tck/pull/452

Many of us are hoping we can move all those tests into a new messaging-tck repo here, but so few of us really understand the TCK at that level, so it's just hopes and dreams at this point.

dblevins commented 3 years ago

I think it's better to wait until we do it, as we may also modernize the TCK so that it's easier to work with it. The current TCK is based on the Java Harness test framework, which is not very convenient nowadays.

My gut instinct is we don't have the luxury to wait till after it's split out to do TCK updates. There's a significant chance splitting it out may not happen. The biggest blocker is there are so few people who understand the TCK harness. I think the more people that are brave enough to dig in as it is now, the higher the chance we can actually get it done.