search

jakartaee / messaging

Jakarta Messaging
https://eclipse.org/ee4j/messaging
Other
39 stars 32 forks source link

Set target release with property #310

Closed pzygielo closed 2 years ago

pzygielo commented 2 years ago

This property is also used by javadoc plugin.

pzygielo commented 2 years ago

May I ask for review, please?

pzygielo commented 2 years ago

Thanks for checking.

  1. This property is shared by https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#release and https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release

  2. Currently generated javadocs link to https://docs.oracle.com/javase/8/docs/api/, per https://github.com/jakartaee/messaging/blob/a59f98b45372f83447778ea22a7fc67797292e23/api/pom.xml#L218

  3. I think the above configuration could be dropped if this property should be used. Will rebase this PR and modify plugin config.

pzygielo commented 2 years ago

We should strive to keep the poms for all APIs in Jakarta EE reasonably consistent.

It's still undecided to do on the parent level:

but messaging is now the only one that has this as a property.

Not sure what you mean by that, for example:

OndroMih commented 2 years ago

I think that until it's decided on the parent level, it's OK to specify this in Messaging. The API now requires Java 11 (see https://github.com/jakartaee/messaging/pull/309 and https://github.com/jakartaee/messaging/pull/313), so it's fine to set it in pom too.

I'm approving and will merge.