jakartaee / nosql

The specification in Jakarta EE to help Jakarta EE developers create enterprise-grade applications using Java® and NoSQL technologies.

https://projects.eclipse.org/projects/ee4j.nosql

Eclipse Public License 2.0

92 stars 28 forks source link

Enhance specification #170

Closed otaviojava closed 8 months ago

otaviojava commented 9 months ago

Changes

Define the entity
Define the basic fields
Define the annotations
Put sample annotation
Include the annotations for compatibility with Jakarta Data
Remove the specializations of templates outside the specifications.

The scope of this PR is to enhance the specification and better describe the annotations we have at Jakarta NoSQL. Furthermore, we focus on the Template interface.

If the team agrees with this enhancement, we can go further to the TCK.

otaviojava commented 9 months ago

Nice alignment of entity-related annotations with Jakarta Persistence. I added a number of review comments which are mostly minor details/grammar.

Nice, this way we can enhance even more the Jakarta Data, mainly at the Polymophism (Polymorphism)/ Inheritance Jakarta

dearrudam commented 9 months ago

@otaviojava it's nice to see annotations like @DiscriminatorColumn and @DiscriminatorValue. Both will help developers implement the single table inheritance strategy, which strategy that is commonly implemented when they're working with NoSQL databases like AWS Dynamo DB.

njr-11 commented 8 months ago

FYI - just in case they were missed in the large amount of comments, there are 2 very minor suggested changes pending. One is a fix to a copyright year and the other is a grammar correction.

otaviojava commented 8 months ago

FYI - just in case they were missed in the large amount of comments, there are 2 very minor suggested changes pending. One is a fix to a copyright year and the other is a grammar correction.

Thank you @njr-11. I fixed it all. There is a lot of work to do here, but with this sync with JPA, we are going on the right path.