jakartaee / persistence

https://jakartaee.github.io/persistence/
Other
196 stars 58 forks source link

Unique index creation #361

Closed dreab8 closed 2 years ago

dreab8 commented 2 years ago

The com/sun/ts/tests/jpa/se/schemaGeneration/annotations/index/Client.java#indexTest test checks for the unique index creation that the generated schema creation script contains ALTER TABLE SCHEMAGENSIMPLE ADD UNIQUE INDEX SCHEMAGENSIMPLE_SVALUE3 or CREATE UNIQUE INDEX SCHEMAGENSIMPLE_SVALUE3 ON SCHEMAGENSIMPLE (SVALUE3) and it fails if ALTER TABLE SCHEMAGENSIMPLE ADD CONSTRAINT SCHEMAGENSIMPLE_SVALUE3 UNIQUE (SVALUE3) is generated instead.

scottmarlow commented 2 years ago

@dreab8 as mentioned in https://jakarta.ee/committees/specification/tckprocess/, this issue needs the challenge label to initiate a TCK challenge.

beikov commented 2 years ago

Note that we can't add a challenge label to the issue

lukasj commented 2 years ago

label added; note that any committer is able to do that

scottmarlow commented 2 years ago

As per https://jakarta.ee/committees/specification/tckprocess, approval is the default after 14 days (March 4 I think), unless the challenge is accepted/denied before then.

lukasj commented 2 years ago

I believe this is purely TCK issue and since it has been resolved there already, time to close this.

beikov commented 2 years ago

Sure, but we would like the challenge to be accepted so that we can exclude the test from the 3.0 TCK

lukasj commented 2 years ago

you don't see the label added about an hour ago?

beikov commented 2 years ago

Sorry, I didn't look careful enough before. All fine :)

lukasj commented 2 years ago

ok